chore(weave): Unit Tests for stack management #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=a082e2cdea7a668d4df762517bb0420a56c1e262 |
gtarpenning
approved these changes
Jun 11, 2024
weave/tests/test_client_trace.py
Outdated
| parent_to_children_map = {} | ||
| roots = [] | ||
| for call in calls: | ||
| if call.parent_id not in parent_to_children_map: |
| ) | ||
| ) | ||
|
|
||
| if POP_REORDERS_STACK: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bunch of unit tests for stack management. Currently the tests pass without code changes. However, given that this area of the code is likely going to get changed soon, i wanted to introduce a few tests to ensure everything is managed correctly.