Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(weave): Update box impl to use python None and bool instead of BoxedNone and BoxedBool #1886

Merged
merged 21 commits into from
Jul 16, 2024
Merged

fix(weave): Update box impl to use python None and bool instead of BoxedNone and BoxedBool #1886

merged 21 commits into from
Jul 16, 2024

Conversation

andrewtruong
Copy link
Collaborator

@andrewtruong andrewtruong commented Jul 8, 2024 •
edited
Loading

@andrewtruong andrewtruong marked this pull request as ready for review July 8, 2024 22:05
@andrewtruong andrewtruong requested a review from a team as a code owner July 8, 2024 22:05
@andrewtruong andrewtruong changed the title fix(weave): Change box impl to use python None instead of BoxedNone fix(weave): Update box impl to use python None and bool isntead of BoxedNone and BoxedBool Jul 16, 2024
@andrewtruong andrewtruong changed the title fix(weave): Update box impl to use python None and bool isntead of BoxedNone and BoxedBool fix(weave): Update box impl to use python None and bool instead of BoxedNone and BoxedBool Jul 16, 2024
@andrewtruong andrewtruong mentioned this pull request Jul 16, 2024
Closed
tssweeney
tssweeney reviewed Jul 16, 2024
View reviewed changes
weave/trace/vals.py
@@ -481,6 +481,8 @@ def make_trace_obj(
box_val = box.box(val)
if isinstance(box_val, pydantic_v1.BaseModel):
box_val.__dict__["ref"] = new_ref
elif box_val is None or isinstance(box_val, bool):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a larger comment here as to why we have this exception and what the implications are

tssweeney
tssweeney approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@tssweeney tssweeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with change request

@andrewtruong andrewtruong merged commit f56fad0 into master Jul 16, 2024
25 checks passed
@andrewtruong andrewtruong deleted the andrew/box branch July 16, 2024 20:34
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tssweeney tssweeney tssweeney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewtruong @tssweeney