Add support for Google Search App detection #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new browser type, Google Search App, has been added to the Browser enumeration in the Detection library. Corresponding unit tests for the Google Search App have also been added to ensure proper identification and version resolution. Ref: #960
BrowserService has been refactored to improve readability by eliminating the redundant usage of private readonly fields. We also added the ability to detect the Google Search App, including its version, enhancing the overall detection capability of the service.
The default name in the Detection/sign.ps1 has been updated to "Open Source Developer, Sarin Na Wangkanai". Simultaneously, the "Detection" function has been enabled in sign.ps1, allowing it to be used in the signing process.
The commit refactors the browser detection by implementing a dedicated function, IsChrome, which improves the Chrome detection process. It also includes the addition of the GetVersionChrome function for parsing the version specifically for Chrome browsers, handling cases with "crios" in the agent string.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new browser type, Google Search App, has been added to the Browser enumeration in the Detection library. Corresponding unit tests for the Google Search App have also been added to ensure proper identification and version resolution.
Ref: #960
CriOS => Chrome iOS
GSA => Google Search App