Increase max thread pane size after a certain point #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proposal to solve the thread pane display on hidpi screens. Cf. <wangp#60>. It will use the previous maximum of 8 rows for the thread pane for terminal sizes of up to 40 rows. For larger terminals it will use 1/5 of the terminal size as the maximum. As it happens, 8/40 = 1/5, which ensures a seamless switch between the two. Switching back to relative size at a certain point removes all hard limits on the maximum thread pane size.
|
It looks reasonable. The larger size does make it more obvious that the code to keep the cursor in the middle of the thread pane needs to be a bit smarter :) |
True. Maybe one could limit the maximum number of empty rows to 4 or something? But I guess that would be another issue. |
|
Merged this one, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to solve the thread pane display on hidpi
screens. Cf. #60. It
will use the previous maximum of 8 rows for the thread pane
for terminal sizes of up to 40 rows. For larger terminals it
will use 1/5 of the terminal size as the maximum. As it happens,
8/40 = 1/5, which ensures a seamless switch between the two.
Switching back to relative size at a certain point removes all
hard limits on the maximum thread pane size.