Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump coverage #16

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Bump coverage #16

merged 1 commit into from
Oct 17, 2023

Conversation

BLKSerene
Copy link
Contributor

@BLKSerene BLKSerene commented Oct 16, 2023 •
edited
Loading

This PR bumps the coverage to nearly 100% (test_translate.py would be updated in another PR). Also some code cleanups and typo fixes.

wannaphong
wannaphong approved these changes Oct 17, 2023
View reviewed changes
Copy link
Owner

@wannaphong wannaphong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! 💯

@wannaphong
Copy link
Owner

@BLKSerene Do you want hacktoberfest?

@BLKSerene
Copy link
Contributor Author

BLKSerene commented Oct 17, 2023 •
edited
Loading

@wannaphong I'm not sure what hacktoberfest refers to. But I think I'm okay with it , so just go ahead.

@wannaphong
Copy link
Owner

@wannaphong I'm not sure what hacktoberfest refers to. But I think I'm okay with it , so just go ahead.

It is an event about open source. https://hacktoberfest.com/

@BLKSerene
Copy link
Contributor Author

@wannaphong Registered.

@wannaphong wannaphong merged commit 0261425 into wannaphong:master Oct 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wannaphong wannaphong wannaphong approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BLKSerene @wannaphong