Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support messages' metadata (e.g. pubsub.Message.Attributes) #3

Merged
merged 2 commits into from
Feb 21, 2019

Conversation

izumin5210
Copy link
Contributor

@izumin5210 izumin5210 commented Feb 19, 2019

No description provided.

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #3 into master will decrease coverage by 0.15%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage    78.8%   78.64%   -0.16%     
==========================================
  Files          15       15              
  Lines         368      370       +2     
==========================================
+ Hits          290      291       +1     
- Misses         70       71       +1     
  Partials        8        8
Impacted Files Coverage Δ
testing/fake_message.go 92.3% <0%> (-7.7%) ⬇️
subscribers/cloudpubsub/message.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1003298...482d69b. Read the comment docs.

@izumin5210
Copy link
Contributor Author

@hlts2 can you review this? 🙏

Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good!!
LGTM👍

@izumin5210 izumin5210 merged commit d67c4fa into master Feb 21, 2019
@izumin5210 izumin5210 deleted the izumin5210/metadata branch February 21, 2019 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants