Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Feature: List secrets in a specified key vault. #3

Merged
merged 4 commits into from
Nov 23, 2020
Merged

Add Feature: List secrets in a specified key vault. #3

merged 4 commits into from
Nov 23, 2020

Conversation

litan1106
Copy link
Contributor

#2

@wapacro
Copy link
Owner

wapacro commented Nov 11, 2020

Hi @litan1106

Many thanks for your contribution. I'll review it in the upcoming days.
In the meantime I'd ask you to provide some test cases for the new feature.

Best,
Roman

@litan1106
Copy link
Contributor Author

litan1106 commented Nov 11, 2020 •
edited
Loading

Many thanks for your contribution. I'll review it in the upcoming days.
In the meantime I'd ask you to provide some test cases for the new feature.

Best,
Roman

Just added the getSecrets tests. Thanks
8ed3d03

@jhoelzl jhoelzl mentioned this pull request Nov 13, 2020
Closed
@wapacro wapacro merged commit 2f89112 into wapacro:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@litan1106 @wapacro