Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete version element #760

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Remove obsolete version element #760

merged 1 commit into from
Apr 15, 2024

Conversation

mattijv
Copy link
Contributor

@mattijv mattijv commented Mar 27, 2024

The V2 of docker compose has always ignored the version element, but recently it started warning about the element being obsolete. This causes annoying spam when running any Warden commands that invoke docker compose.

This PR removes the version element from all docker compose config fragments, fixing #758.

@mattijv
Remove obsolete version element
acb0d1c 
The V2 of docker compose has always ignored the version element, but
recently it started warning about the element being obsolete. This
causes annoying spam when running any Warden commands that invoke docker
compose.

This commit removes the version element from all docker compose config
fragments.
IvanChepurnyi
IvanChepurnyi approved these changes Apr 10, 2024
View reviewed changes
Copy link

@IvanChepurnyi IvanChepurnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been receiving spam of those messages after upgrading to a newer version of docker-compose. The changes look good to me, but it is up to the maintainer to approve them.

@ihor-sviziev
Copy link
Contributor

I also getting these warnings while running warden env up after upgrading to Docker Desktop 4.29.0 with Docker Compose v2.26.1-desktop.1.
image

@navarr navarr added this pull request to the merge queue Apr 15, 2024
Merged via the queue into wardenenv:main with commit 01dd640 Apr 15, 2024
@MagePsycho
Copy link

MagePsycho commented May 30, 2024 •
edited
Loading

I am also getting these errors (after upgrading the OrbStack)

WARN[0000] /opt/homebrew/Cellar/warden/0.14.2/environments/includes/networks.base.yml: `version` is obsolete
WARN[0000] /opt/homebrew/Cellar/warden/0.14.2/environments/includes/php-fpm.base.yml: `version` is obsolete
WARN[0000] /opt/homebrew/Cellar/warden/0.14.2/environments/includes/php-fpm.darwin.yml: `version` is obsolete
WARN[0000] /opt/homebrew/Cellar/warden/0.14.2/environments/includes/nginx.base.yml: `version` is obsolete
WARN[0000] /opt/homebrew/Cellar/warden/0.14.2/environments/includes/nginx.darwin.yml: `version` is obsolete
WARN[0000] /opt/homebrew/Cellar/warden/0.14.2/environments/includes/db.base.yml: `version` is obsolete
WARN[0000] /opt/homebrew/Cellar/warden/0.14.2/environments/symfony/db.base.yml: `version` is obsolete
WARN[0000] /opt/homebrew/Cellar/warden/0.14.2/environments/includes/elastichq.base.yml: `version` is obsolete
WARN[0000] /opt/homebrew/Cellar/warden/0.14.2/environments/symfony/symfony.base.yml: `version` is obsolete

When should we expect a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@IvanChepurnyi IvanChepurnyi IvanChepurnyi approved these changes

@navarr navarr navarr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattijv @ihor-sviziev @MagePsycho @navarr @IvanChepurnyi