Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #12 #18

Merged
merged 2 commits into from
Jan 9, 2021
Merged

issue #12 #18

merged 2 commits into from
Jan 9, 2021

Conversation

JohnDoePBabu
Copy link
Collaborator

#12 Better error handling

JohnDoePBabu and others added 2 commits January 9, 2021 16:30
* [] Convert to promises

* Add failure tests

Co-authored-by: ty08 <Shreyas.Babu@in.tesco.com>
Co-authored-by: ty08 <Shreyas.Babu@tesco.com>
Copy link
Owner

@warengonzaga warengonzaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me... I'll merge it.

@warengonzaga warengonzaga merged commit 0fa118d into warengonzaga:dev Jan 9, 2021
@warengonzaga warengonzaga mentioned this pull request Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants