Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak display of the image and this box-shadow #48

Merged
merged 4 commits into from
Oct 26, 2021
Merged

tweak display of the image and this box-shadow #48

merged 4 commits into from
Oct 26, 2021

Conversation

thomasbnt
Copy link
Collaborator

@thomasbnt thomasbnt commented Oct 26, 2021 •
edited
Loading

  • Edited display of the image and the box-shadow
  • Edited size of the favicon.svg
  • Added user-select: none to $
  • bmcjs main image isn't anymore draggable
bmsjs_pr_edit_logo_website.mp4

@thomasbnt thomasbnt added docs Issue/Pull Request Label for Docs tweak Issue/Pull Request for Tweaks p1 in review Issue/Pull Request Label for In Review Status labels Oct 26, 2021
@thomasbnt thomasbnt added this to the BuyMeaCoffeeJS v2 milestone Oct 26, 2021
@thomasbnt thomasbnt self-assigned this Oct 26, 2021
@vercel
Copy link

vercel bot commented Oct 26, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/warengonzaga/buymeacoffeejs/3BB3G3NxmmpQZfRNzkWZNCpisBjL
✅ Preview: https://buymeacoffeejs-git-edit-logo-position-websi-81534f-warengonzaga.vercel.app

@warengonzaga warengonzaga added hacktoberfest Hacktoberfest Related Pull Request or Issue. hacktoberfest-accepted Hacktoberfest Accepted Pull Request. and removed in review Issue/Pull Request Label for In Review Status labels Oct 26, 2021
warengonzaga
warengonzaga approved these changes Oct 26, 2021
View reviewed changes
Copy link
Owner

@warengonzaga warengonzaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tweak! Also good catch! 👊
I'll merge this, automagically included to #44

@warengonzaga warengonzaga merged commit f100f48 into dev Oct 26, 2021
@warengonzaga warengonzaga changed the title Edit display of the image and this box-shadow tweak display of the image and this box-shadow Oct 26, 2021
@thomasbnt thomasbnt deleted the edit-logo-position-website-thomasbnt-issue#42 branch October 26, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warengonzaga warengonzaga warengonzaga approved these changes

Assignees

@thomasbnt thomasbnt

Labels
docs Issue/Pull Request Label for Docs hacktoberfest Hacktoberfest Related Pull Request or Issue. hacktoberfest-accepted Hacktoberfest Accepted Pull Request. tweak Issue/Pull Request for Tweaks
Projects
None yet
Milestone
v2.0.0 📦
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasbnt @warengonzaga