Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Popup requires key" setting sometimes gets ignored #10

Closed
o0o0 opened this issue Nov 19, 2018 · 4 comments
Closed

"Popup requires key" setting sometimes gets ignored #10

o0o0 opened this issue Nov 19, 2018 · 4 comments
Labels

Comments

@o0o0
Copy link
Contributor

o0o0 commented Nov 19, 2018

I have the popup key set to shift, but sometimes nazeka ignores this and behaves according to the default settings (no popup key). This seems to happen randomly, and refreshing the page always fixes the problem.
When this bug does appear, it doesn't affect all of my open tabs, it only happens on an individual tab basis.

@wareya
Copy link
Owner

wareya commented Nov 19, 2018

Interesting. Is keyboard focus on something else? Does it only happen on certain pages?

@o0o0
Copy link
Contributor Author

o0o0 commented Nov 20, 2018

It can happen on any page.
I think I managed to reproduce the behavior.
Set the popup key to ctrl, bring up the definitions window and then use ctrl+tab or ctrl+number to switch tabs while the popup is still open. When you switch back to the original tab, the popups will continue to show up without using the ctrl key.
The same thing happens when I set the popup key to shift and use shift+k in Vimium to switch tabs. However, it works properly if the two actions don't use the same modifier key.

@wareya
Copy link
Owner

wareya commented Nov 20, 2018

I see, yeah, that prevents the keyup even from firing. I'll look into it.

@wareya wareya added the bug label Dec 23, 2018
@wareya wareya mentioned this issue Jun 17, 2019
@wareya
Copy link
Owner

wareya commented Jun 30, 2019

I did something that I think should fix this. Feel free to post again if the next update doesn't fix this.

@wareya wareya closed this as completed Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants