Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function to manually setup proxy. Useful on iOS where getenv doesn't return proxy settings #16

Closed
wants to merge 1 commit into from

Conversation

shyswork
Copy link
Contributor

On iOS getenv("http_proxy") doesn't return proxy settings so you have to use some iOS SDK (CFNetwork) calls to get proxy. I have added this function to be able to set proxy manually after I got it from system. I have considered also to add proxy setting as a parameter to libwebsocket_create_context but I thought it would be to intrusive and not that commonly used. Please check if it suits the overall style of library since maybe I have missed something. If the code is not OK, please add the functionality to set proxy as you think would be best.

@warmcat
Copy link
Collaborator

warmcat commented Oct 24, 2013

On 24/10/13 20:46, the mail apparently from shyswork included:

On iOS getenv("http_proxy") doesn't return proxy settings so you have to
use some iOS SDK (CFNetwork) calls to get proxy. I have added this
function to be able to set proxy manually after I got it from system. I
have considered also to add proxy setting as a parameter to
libwebsocket_create_context but I thought it would be to intrusive and
not that commonly used. Please check if it suits the overall style of
library since maybe I have missed something. If the code is not OK,
please add the functionality to set proxy as you think would be best.

Thanks I simplified the code a bit and hopefully didn't break it.

http://git.libwebsockets.org/cgi-bin/cgit/libwebsockets/commit/?id=b4e800e333f66bec56ad22f6e3cf1455618d4305

-Andy


    You can merge this Pull Request by running

git pull https://github.com/shyswork/libwebsockets master

Or view, comment on, or merge it at:

#16

    Commit Summary

@shyswork
Copy link
Contributor Author

Thanks for quick response.

@shyswork shyswork closed this Oct 24, 2013
@yj1851 yj1851 mentioned this pull request Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants