Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Brokers before firing Tub.stopService Deferred #38

Merged
merged 2 commits into from
Jul 26, 2017

Conversation

exarkun
Copy link
Collaborator

@exarkun exarkun commented Jul 26, 2017

@codecov-io
Copy link

Codecov Report

Merging #38 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   84.14%   84.18%   +0.04%     
==========================================
  Files          60       60              
  Lines        8912     8924      +12     
  Branches     1372     1374       +2     
==========================================
+ Hits         7499     7513      +14     
+ Misses       1000      999       -1     
+ Partials      413      412       -1
Impacted Files Coverage Δ
src/foolscap/pb.py 88.78% <100%> (+0.06%) ⬆️
src/foolscap/broker.py 84.91% <100%> (+0.51%) ⬆️
src/foolscap/referenceable.py 89.34% <0%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c1aace...24c9f91. Read the comment docs.

@warner
Copy link
Owner

warner commented Jul 26, 2017

looks good to me

@warner warner merged commit 24c9f91 into warner:master Jul 26, 2017
@exarkun exarkun deleted the 274.clean-tub-stopservice branch July 26, 2017 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants