der: fix encoding and decoding OIDs #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make the code handle oids with a large second subidentifier (fixes tlsfuzzer#155) make the code raise correct exception when the encoded multi-byte subidentifier is missing the last byte move OID test coverage to test_der module and extend it update the OID generators in random DER generator to generate OIDs with large second subidentifier
ep69
approved these changes
Nov 5, 2019
the X.690 refers to bits from 1 to 8 rather than from 0 to 7 use the "MSB" as an unambiguous name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make the code handle oids with a large second subidentifier (fixes #155)
make the code raise correct exception when the encoded multi-byte
subidentifier is missing the last byte
move OID test coverage to test_der module and extend it
update the OID generators in random DER generator to generate OIDs with
large second subidentifier