Skip to content

make scale() thread-safe #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 18, 2019
Merged

make scale() thread-safe #177

merged 2 commits into from
Dec 18, 2019

Conversation

tomato42
Copy link
Member

fixes #176

@tomato42 tomato42 added the bug unintended behaviour in ecdsa code label Dec 16, 2019
@tomato42 tomato42 added this to the v0.15 milestone Dec 16, 2019
@tomato42 tomato42 self-assigned this Dec 16, 2019
@coveralls
Copy link

coveralls commented Dec 16, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 93.609% when pulling 1d3b3c6 on tomato42:thread-safe-scale into 5b99264 on warner:master.

@tomato42 tomato42 force-pushed the thread-safe-scale branch 2 times, most recently from 90d7a38 to 6d9b08c Compare December 18, 2019 14:38
t8m
t8m approved these changes Dec 18, 2019
View reviewed changes
Copy link

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not really review the RWLock implementation, hopefully that is fine. Otherwise LGTM.

@tomato42 tomato42 merged commit e9b1122 into tlsfuzzer:master Dec 18, 2019
@tomato42 tomato42 deleted the thread-safe-scale branch December 18, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@t8m t8m t8m approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@tomato42 tomato42

Labels
bug unintended behaviour in ecdsa code
Projects
None yet
Milestone
v0.15
Development

Successfully merging this pull request may close these issues.

scale() should be thread-safe
3 participants
@tomato42 @coveralls @t8m