-
Notifications
You must be signed in to change notification settings - Fork 331
Fix for Python 3.10, 4 and 10 #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The Python 3.4 failure is unrelated and also happens on |
we are targeting all python versions that have support, be it from community in Debian or from Red Hat in RHEL, we don't limit ourselves to upstream python support |
Sure, I guess you'll need to pin some more dependencies. |
ok, builds should be fixed with #183, could you rebase on current master? |
061dc8c
to
0cbfad8
Compare
Done and Travis is ✅! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
You're welcome, thank you for maintaining ecdsa! |
It's generally safer to compare to the
sys.version_info
tuple than thesys.version
string, which can include assumptions that each version component is always a single character.There's also some code which uses
six.PY3
, similar to:Where:
When run on Python 4, this will run the Python 2 code!
Instead, use
six.PY2
.Found with https://github.com/asottile/flake8-2020.