Format with black

[hukkin]

• Edited tox.ini:
  • Format every python file with black (pinned to version 19.10b0)
  • Use line length 79 for black (this is the flake8 default).
• Ran black --line-length 79 . to auto-format every python file

This automatically fixes flake8 errors of types E111,E114,E226,E231,E266,E302,E305,E502,W391.

Possible closes #171

[coveralls]

Coverage decreased (-0.05%) to 96.989% when pulling f757a23 on hukkinj1:black into c00a19a on warner:master.

[hukkin]

Two questions @tomato42:

1. You mentioned in the issue a line length of 80. I used 79 here because that is the flake8 setting currently in use. I can change to 80 chars if you want?
2. I set the black configuration (i.e. the altered line length) as a CLI arg in tox.ini. An alternative is creating a pyproject.toml file and adding the configuration there. Downside: one more conf file, upside: the conf is applied when calling black outside tox.ini (e.g. IDE autoformatter, pre-commit hooks etc.).

[tomato42]

shouldn't we be able to remove this one too?

[hukkin]

Theres a bunch of lines like

_b = 0x051953EB9618E1C9A1F929A21A0B68540EEA2DA725B99B315F3B8B489918EF109E156193951EC7E937B1652C0BD3BB1BF073573DF883D2C34F1EF451FD46B503F00

which is something black will not fix. These need to be manually sliced or we have to add # noqa: E501 comments on these lines (personally would prefer the latter). This could also be a separate MR?

[tomato42]

those can be translated to int("0x0519...", 16) this is the approach we are already using for a lot of constants like this

I guess we can do it as a separate PR...

[tomato42]

moved to #187

[tomato42]

why the length limit is excluded in pylint?

[hukkin]

Do you perhaps mean flake8? Seems to me that this project is not using pylint.

That check is ignored due to lines like the one mentioned here #186 (comment)

Autoformatter wont be able to fix these.

[tomato42]

ok, let's move E501 to a separate issue