🚫🥒 do not pickle the unpickleable RWLock

[adhintz]

This is to fix the can't pickle thread.lock objects error when attempting to pickle something such as an ecdsa.keys.VerifyingKey

Alternatively, the custom getstate and setstate could be within the RWLock class.

[coveralls]

Coverage increased (+0.01%) to 96.988% when pulling e0840fa on adhintz:master into a776084 on warner:master.

[tomato42]

Could you add a test case to verify that the object is pickleable? and that unpickling gives an equal object?

[tomato42]

also black seems to complain about formatting, please fix that too

[adhintz]

Thanks for the response! While writing the test, I cannot get equality comparisons working for PointJacobi objects. Debugging __eq__ in PointJacobi, it's deciding two PointJacobi objects with the same values are not equal because of if self.__curve != other.curve(): Although class CurveFp defines __eq__, it appears to be doing an identity comparison and not using the CurveFp __eq__. Here's an example test case:

self = <ecdsa.test_jacobi.TestJacobi testMethod=test_can_pickle>

    def test_can_pickle(self):
        pj1 = PointJacobi(curve=CurveFp(23, 1, 1, 1), x=2, y=3, z=1, order=1)
        pj2 = PointJacobi(curve=CurveFp(23, 1, 1, 1), x=2, y=3, z=1, order=1)
>       self.assertEqual(pj1, pj2)
E       AssertionError: <ecdsa.ellipticcurve.PointJacobi object at 0x7f4a0260f0d0> != <ecdsa.ellipticcurve.PointJacobi object at 0x7f4a0260f250>

Any idea what I'm doing wrong?

[adhintz]

I figured out my question on the equality comparison of PointJacobi. CurveFp has __eq__ defined, but not __ne__. I'll add this to class CurveFp:

    def __ne__(self, other):
        return not self.__eq__(other)

[tomato42]

It reformmated some lines I hadn't modified

likely new version, that's ok

[tomato42]

Looks good, thank you!