add hkdf as dependency and correct PyPy2 #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Closed
asymmetric
reviewed
Nov 13, 2016
| @@ -2,8 +2,8 @@ | |||
| # Pure-Python SPAKE2 | |||
|
|
|||
| * License: MIT | |||
| * Dependencies: none (pure-python) | |||
| * Compatible With: Python 2.6, 2.7, 3.3, 3.4, 3.5, pypy2 | |||
| * Dependencies: hkdf (pure-python) | |||
There was a problem hiding this comment.
I would loose the (pure-python) here.
|
Fixes #7. |
|
@asymmetric updated |
|
I'm good with the first two patches.. I'll land that now. I think I'd like to leave the "Pure-Python SPAKE2" headline in the README, since not needing a C compiler is what's special about this particular library (and the HKDF dependency doesn't need a C compiler either). thanks! |
|
merged first two patches in eb11820 , omitting final patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.