-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(alert): use imported instead of inline classes #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarolineGard
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
github-actions bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
# [1.0.0-alpha.20](v1.0.0-alpha.19...v1.0.0-alpha.20) (2023-06-01) ### Bug Fixes * **alert:** use imported instead of inline classes ([#22](#22)) ([2f37560](2f37560))
github-actions bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
# 1.0.0 (2023-08-31) ### Bug Fixes * **@warp-ds/toast:** remove window reference from toast api bundle, fixing server-side rendering ([677c7ed](677c7ed)) * add component classes to card component ([#18](#18)) ([d8af2fc](d8af2fc)) * add missing package-lock ([#24](#24)) ([5bc0dbd](5bc0dbd)) * add release step with semantic releases and eik ([#5](#5)) ([6363e52](6363e52)) * add styles to textfield ([#11](#11)) ([ed88c35](ed88c35)) * add tokens to button element ([77b3469](77b3469)) * Add Warp component-classes to the box component ([#12](#12)) ([fd55937](fd55937)) * add Warp component-classes to the breadcrumbs component ([#14](#14)) ([eb6763a](eb6763a)) * **alert:** use imported instead of inline classes ([#22](#22)) ([2f37560](2f37560)) * build ([7792404](7792404)) * bump packages ([#23](#23)) ([aa73bae](aa73bae)) * **docs:** set fonts' rem base on docs page to be 10px ([#25](#25)) ([38e6781](38e6781)) * **expandable:** add _hasTitle again to expandable classes ([199b146](199b146)) * **expandable:** bumb warp versions ([1f8a983](1f8a983)) * **expandable:** fix chevron issue ([#28](#28)) ([fc9481f](fc9481f)) * **expandable:** fix icon issue ([6cbd8db](6cbd8db)) * fix build ([9a8b2d4](9a8b2d4)) * guards ([dfa1ba0](dfa1ba0)) * make styles on components work ([#9](#9)) ([0aae500](0aae500)) * **package.json:** build toast api to publish missing scripts ([#39](#39)) ([f73dd2f](f73dd2f)) * **package.json:** bump semantic-release to 21.0.7 ([#36](#36)) ([61f034a](61f034a)) * **package.json:** remove unused dependency that caused deployment errors ([#16](#16)) ([a447c62](a447c62)) * **package.json:** update versions ([#29](#29)) ([feb0ccf](feb0ccf)) * provide correct import of windowExists after refactoring ([#41](#41)) ([7ada8bd](7ada8bd)) * **release.yml:** set pnpm version to 8 to fix recursive install errors ([#15](#15)) ([21afc96](21afc96)) * remove bad code ([97d8068](97d8068)) * remove comments wrapping [@unocss-placeholder](https://github.com/unocss-placeholder) in components styles ([#19](#19)) ([862c8cd](862c8cd)) * remove inline class from button link ([#26](#26)) ([0a87895](0a87895)) * secondary and not quiet fix ([51b76b3](51b76b3)) * **select:** add component classes to select ([#33](#33)) ([8bdb2f5](8bdb2f5)) * stable FINN prod alpha-release ([#32](#32)) ([8351ef2](8351ef2)) * **toast:** update classes + fix color issue on icons ([#27](#27)) ([0f09a39](0f09a39)) * try vite build ([ffdeb02](ffdeb02)) * update @warp-ds/uno and /css to 1.0.0 ([#44](#44)) ([44aca9a](44aca9a)) * use css packages instead of component-classes ([#31](#31)) ([1bf8a0a](1bf8a0a)) ### Features * **alert:** warpify alert component ([#17](#17)) ([2a01030](2a01030)) * **attention:** warpify attention ([#21](#21)) ([79b5b64](79b5b64)) * **expandable:** add warp component classes for expandable ([3a28e93](3a28e93)) * **toast:** warpify toast ([#20](#20)) ([d1dc939](d1dc939)) * **workflows:** add eik aliasing script to release.yml ([#10](#10)) ([bc4a76f](bc4a76f)) ### Reverts * Revert "chore(release): 1.0.0-alpha.28 [skip ci]" (#35) ([4770de9](4770de9)), closes [#35](#35)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on respective @warp-ds/component-classes changes and last-child class support