feat: Add money and text bold, italic, strikethrough and underline icons #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnuh
reviewed
Jul 8, 2024
default-icon-descriptions.js
Outdated
| @@ -2254,6 +2264,11 @@ export default { | |||
| id: "icon.title.stove", | |||
| comment: "Title for stove icon" | |||
| }, | |||
| strikethrough: { | |||
| message: "Strikethrough", | |||
magnuh
reviewed
Jul 8, 2024
default-icon-descriptions.js
Outdated
| @@ -2464,6 +2479,11 @@ export default { | |||
| id: "icon.title.umbrella", | |||
| comment: "Title for umbrella icon" | |||
| }, | |||
| underline: { | |||
magnuh
reviewed
Jul 8, 2024
magnuh
reviewed
Jul 8, 2024
src/raw/text-bold/icon_32.svg
Outdated
| @@ -0,0 +1,10 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" width="36" height="32" fill="none" viewBox="0 0 36 32"> | |||
There was a problem hiding this comment.
Wrong viewBox and width values... should be set to 32.
magnuh
reviewed
Jul 8, 2024
src/raw/text-bold/icon_16.svg
Outdated
| @@ -0,0 +1,10 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="none" viewBox="0 0 16 16"> | |||
| <g clip-path="url(#a)"> | |||
There was a problem hiding this comment.
clipPaths and defs should be removed. Applies to all text-underline, text-bold, text-italic and text-strikethrough icons in this PR.
magnuh
reviewed
Jul 8, 2024
magnuh
changed the title
…t-italic, text-strikethrough and text-underline
felicia-haggqvist
approved these changes
Jul 9, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
# [2.1.0-next.1](v2.0.3-next.4...v2.1.0-next.1) (2024-07-09) ### Features * Add money and text bold, italic, strikethrough and underline icons ([#116](#116)) ([181d6de](181d6de))
github-actions bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
# [2.1.0](v2.0.2...v2.1.0) (2024-08-15) ### Bug Fixes * Add translations that were gone from crowdin ([#114](#114)) ([9c01b01](9c01b01)) * Adjust which hex values to be replaced with 'currentColor' ([#120](#120)) ([462765e](462765e)) * bump pnpm version 8 to 9 ([82354bf](82354bf)) * Change to correct size 16 Tag icon ([#122](#122)) ([4d9fa88](4d9fa88)) * Check for process variable and removed undefined texts ([#126](#126)) ([7e2c9ca](7e2c9ca)) * support danish locale ([#112](#112)) ([9fca432](9fca432)) ### Features * Add money and text bold, italic, strikethrough and underline icons ([#116](#116)) ([181d6de](181d6de)) * revert some rimrafs as they removed output ([5c79ab3](5c79ab3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added five new icons and updated the default-icon-descriptions.js file. What's left is to run pnpm i18n:get-sorted-locales and pnpm build.