-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add money and text bold, italic, strikethrough and underline icons #116
Conversation
default-icon-descriptions.js
Outdated
@@ -2254,6 +2264,11 @@ export default { | |||
id: "icon.title.stove", | |||
comment: "Title for stove icon" | |||
}, | |||
strikethrough: { | |||
message: "Strikethrough", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Strikethrough text"?
default-icon-descriptions.js
Outdated
@@ -2464,6 +2479,11 @@ export default { | |||
id: "icon.title.umbrella", | |||
comment: "Title for umbrella icon" | |||
}, | |||
underline: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Underline text"?
src/raw/text-bold/icon_32.svg
Outdated
@@ -0,0 +1,10 @@ | |||
<svg xmlns="http://www.w3.org/2000/svg" width="36" height="32" fill="none" viewBox="0 0 36 32"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong viewBox and width values... should be set to 32.
src/raw/text-bold/icon_16.svg
Outdated
@@ -0,0 +1,10 @@ | |||
<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="none" viewBox="0 0 16 16"> | |||
<g clip-path="url(#a)"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clipPaths and defs should be removed. Applies to all text-underline, text-bold, text-italic and text-strikethrough icons in this PR.
…t-italic, text-strikethrough and text-underline
# [2.1.0-next.1](v2.0.3-next.4...v2.1.0-next.1) (2024-07-09) ### Features * Add money and text bold, italic, strikethrough and underline icons ([#116](#116)) ([181d6de](181d6de))
# [2.1.0](v2.0.2...v2.1.0) (2024-08-15) ### Bug Fixes * Add translations that were gone from crowdin ([#114](#114)) ([9c01b01](9c01b01)) * Adjust which hex values to be replaced with 'currentColor' ([#120](#120)) ([462765e](462765e)) * bump pnpm version 8 to 9 ([82354bf](82354bf)) * Change to correct size 16 Tag icon ([#122](#122)) ([4d9fa88](4d9fa88)) * Check for process variable and removed undefined texts ([#126](#126)) ([7e2c9ca](7e2c9ca)) * support danish locale ([#112](#112)) ([9fca432](9fca432)) ### Features * Add money and text bold, italic, strikethrough and underline icons ([#116](#116)) ([181d6de](181d6de)) * revert some rimrafs as they removed output ([5c79ab3](5c79ab3))
Added five new icons and updated the default-icon-descriptions.js file. What's left is to run pnpm i18n:get-sorted-locales and pnpm build.