Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check for process variable and removed undefined texts #126

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

imprashast
Copy link
Contributor

What's done:

  • Add optional chaining to the process variable when reading NMP_BRAND
  • i18n script read svgs from the dist folder (see getSVGs() in helper.js), so the deleted icons which were still present in my dist folder got a locale file with undefined text. Adding rimraf dist to all the build script will fix this problem forever

@imprashast imprashast self-assigned this Aug 15, 2024
@imprashast imprashast requested a review from a team August 15, 2024 08:01
@imprashast imprashast merged commit 7e2c9ca into next Aug 15, 2024
1 check passed
@imprashast imprashast deleted the fix-process branch August 15, 2024 08:14
github-actions bot pushed a commit that referenced this pull request Aug 15, 2024
# [2.1.0-next.3](v2.1.0-next.2...v2.1.0-next.3) (2024-08-15)

### Bug Fixes

* Check for process variable and removed undefined texts ([#126](#126)) ([7e2c9ca](7e2c9ca))
github-actions bot pushed a commit that referenced this pull request Aug 15, 2024
# [2.1.0](v2.0.2...v2.1.0) (2024-08-15)

### Bug Fixes

* Add translations that were gone from crowdin ([#114](#114)) ([9c01b01](9c01b01))
* Adjust which hex values to be replaced with 'currentColor' ([#120](#120)) ([462765e](462765e))
* bump pnpm version 8 to 9 ([82354bf](82354bf))
* Change to correct size 16 Tag icon ([#122](#122)) ([4d9fa88](4d9fa88))
* Check for process variable and removed undefined texts ([#126](#126)) ([7e2c9ca](7e2c9ca))
* support danish locale ([#112](#112)) ([9fca432](9fca432))

### Features

* Add money and text bold, italic, strikethrough and underline icons  ([#116](#116)) ([181d6de](181d6de))
* revert some rimrafs as they removed output ([5c79ab3](5c79ab3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants