Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: build react/vue/elements icons #4

Merged
merged 6 commits into from
Sep 12, 2023
Merged

feat: build react/vue/elements icons #4

merged 6 commits into from
Sep 12, 2023

Conversation

AnnaRybkina
Copy link
Contributor

@AnnaRybkina AnnaRybkina commented Sep 5, 2023 •
edited by BalbinaK
Loading

Background: https://nmp-jira.atlassian.net/jira/software/projects/WARP/boards/15?selectedIssue=WARP-224

  • build icons for react
  • build icons for vue
  • build icons for elements
  • add eik import-map

Publishing to NPM and EIK we will be handled in a separate PR.

@AnnaRybkina AnnaRybkina changed the base branch from main to alpha September 5, 2023 13:57
@AnnaRybkina AnnaRybkina requested a review from a team September 7, 2023 06:03
BalbinaK
BalbinaK reviewed Sep 8, 2023
View reviewed changes
Copy link
Contributor

@BalbinaK BalbinaK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comments that made me think that we should maybe handle publishing/automated releases in a separate PR. This PR is already a bit too big imo ☺️

On that note, I think we should aim at having smaller PRs in the future. Especially when we squash-merge PRs that are not going intomain. The commit messages then don't cover all that has been changed well enough in my opinion. It's also easier to get good reviews when there's less to look through in the changed files 😊

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated
"dev": "vite",
"vite:build": "vite build",
"preview": "pnpm run build && vite build && vite preview"
"preview": "pnpm run build && vite build && vite preview",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to align with other examples :)

Suggested change
"preview": "pnpm run build && vite build && vite preview",
"preview": "pnpm build && vite build && vite preview",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in da0b941. Here I also renamed the command that shows a preview of all icons to pnpm dev. This way all our repos have a similar command to see the output of that package locally. Tested that the output is the same when using pnpm build && vite as in pnpm build && vite build && vite preview.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@BalbinaK
Copy link
Contributor

BalbinaK commented Sep 8, 2023

I opened a PR just for updating dependencies: #6 so we can include fewer changes in this PR.

@BalbinaK BalbinaK changed the base branch from alpha to chore/update-dependencies September 8, 2023 13:51
Base automatically changed from chore/update-dependencies to alpha September 8, 2023 14:03
AnnaRybkina and others added 2 commits September 11, 2023 12:17
@AnnaRybkina @BalbinaK
fix: add necessary config to be able to build correct imports with ei…
66b28b9 
…k plugin
@BalbinaK
See a preview of all icons using pnpm dev command
da0b941 
Align with other warp-ds repos on how we can check the output in the form of a running 'docs page.
@BalbinaK
Copy link
Contributor

Sorry for the mess. I wanted to move the logic for automating releases out to make the changes easier to review. There's a draft PR for handling automated releases here: #7.

siljec
siljec approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@siljec siljec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@BalbinaK BalbinaK merged commit 362deca into alpha Sep 12, 2023
@BalbinaK BalbinaK deleted the feat/build-react-icons branch September 12, 2023 07:09
github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
@semantic-release-bot
chore(release): 1.0.0-alpha.1 [skip ci]
7f8987b 
# 1.0.0-alpha.1 (2023-09-12)

### Features

* add automated release ([#7](#7)) ([d0cfcc1](d0cfcc1))
* build react/vue/elements icons ([#4](#4)) ([362deca](362deca))
* initial import of all icons from Figma ([#1](#1)) ([23cccb2](23cccb2))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
4c5b359 
# 1.0.0 (2023-09-20)

### Features

* add automated release ([#7](#7)) ([d0cfcc1](d0cfcc1))
* build react/vue/elements icons ([#4](#4)) ([362deca](362deca))
* initial import of all icons from Figma ([#1](#1)) ([23cccb2](23cccb2))
github-actions bot pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
chore(release): 1.0.0-next.1 [skip ci]
53a0493 
# 1.0.0-next.1 (2023-09-20)

### Features

* add automated release ([#7](#7)) ([d0cfcc1](d0cfcc1))
* build react/vue/elements icons ([#4](#4)) ([362deca](362deca))
* initial import of all icons from Figma ([#1](#1)) ([23cccb2](23cccb2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalbinaK BalbinaK BalbinaK left review comments

@siljec siljec siljec approved these changes

@magnuh magnuh Awaiting requested review from magnuh

Assignees
No one assigned
Labels
released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnnaRybkina @BalbinaK @siljec @magnuh