chore: use new Vue builtin defineModel #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pearofducks thanks for the update! It looks like v3 in https://assets.finn.no/npm/vue/v3 is redirecting to 3.4.3 already. Or did you mean https://assets.finn.no/pkg/vue (I couldn't find any aliases but this url shows v 3.0.6). We'll review and test your changes as soon as possible. Let us know if there anything in particular you think we should double-check here 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops a dependency and moves to use a new Vue builtin - defineModel.
This can't be released until the Eik version/alias of Vue is updated to Vue 3.4. But that should be relatively trivial to take care of.