Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename deleted icons after @warp-ds/icons update to 2.0.0 #136

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

BalbinaK
Copy link
Contributor

Description

Fixes WARP-498

This PR updates @warp-ds/icons dependency to 2.0.0 and replaces deprecated icons with the suggested equivalents:

What's changed

Rename deprecated alert- icons in Alert component

Screenshot of Alert component variants with the new outlined icons

Use arrow-left icon as back button in Modal component:

Screenshot of Modal component with back button using an arrow-left icon

@BalbinaK BalbinaK requested a review from a team February 12, 2024 12:08
Copy link
Contributor

@felicia-haggqvist felicia-haggqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@BalbinaK BalbinaK merged commit e9ad066 into next Feb 13, 2024
3 checks passed
@BalbinaK BalbinaK deleted the fix/update-icons-to-v2 branch February 13, 2024 08:26
github-actions bot pushed a commit that referenced this pull request Feb 13, 2024
## [1.2.4-next.3](v1.2.4-next.2...v1.2.4-next.3) (2024-02-13)

### Bug Fixes

* rename deleted icons after @warp-ds/icons update to 2.0.0 ([#136](#136)) ([e9ad066](e9ad066))
github-actions bot pushed a commit that referenced this pull request Feb 15, 2024
## [1.2.4](v1.2.3...v1.2.4) (2024-02-15)

### Bug Fixes

* **deps:** update all dependencies (non-major) ([#132](#132)) ([c2b2131](c2b2131))
* **deps:** update dependency scroll-doctor to v2 ([#134](#134)) ([7e7e919](7e7e919))
* Remove redundant component css class from Modal ([#137](#137)) ([3d783f9](3d783f9))
* rename deleted icons after @warp-ds/icons update to 2.0.0 ([#136](#136)) ([e9ad066](e9ad066))
* replace letter x with icon close ([#129](#129)) ([56763e5](56763e5))
* Slider active track disabled state fix ([#139](#139)) ([a756c4c](a756c4c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants