Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: small prop missing on toggles #142

Merged
merged 5 commits into from
Mar 7, 2024
Merged

fix: small prop missing on toggles #142

merged 5 commits into from
Mar 7, 2024

Conversation

pearofducks
Copy link
Contributor

No description provided.

@pearofducks pearofducks requested a review from a team February 26, 2024 11:48
@BalbinaK
fix(toggle): pass small prop down to w-toggle-item
6b3906b 
This together with adding 'small' prop to the props model ensures correct styling is applied to
radio-button label
@BalbinaK
fix(toggle-item): apply 'small' label style only with radio-button …
79c08eb 
…type

According to design, the 'small' prop is only relevant to Toggle of type 'radio-button'.
@BalbinaK
Copy link
Contributor

We've learned from the designers that there was never supposed to be a small checkbox or small radio Toggle - only Toggle of type 'radio-button' should be possible to made "small". I added an example of that to the Vue docs, as well as an additional check whether the small prop is passed together with a radioButton prop (see commit history).
Screenshot of a small and regular Toggle component of 'radio-button' type

@BalbinaK BalbinaK mentioned this pull request Mar 5, 2024
Merged
felicia-haggqvist
felicia-haggqvist approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@felicia-haggqvist felicia-haggqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@BalbinaK BalbinaK merged commit 5a7931b into next Mar 7, 2024
5 checks passed
@BalbinaK BalbinaK deleted the fix-missing-prop branch March 7, 2024 08:37
github-actions bot pushed a commit that referenced this pull request Mar 7, 2024
@semantic-release-bot
chore(release): 1.2.5-next.1 [skip ci]
ef52b53 
## [1.2.5-next.1](v1.2.4...v1.2.5-next.1) (2024-03-07)

### Bug Fixes

* small prop missing on toggles ([#142](#142)) ([5a7931b](5a7931b))
github-actions bot pushed a commit that referenced this pull request Mar 7, 2024
@semantic-release-bot
chore(release): 1.2.5 [skip ci]
aa045a6 
## [1.2.5](v1.2.4...v1.2.5) (2024-03-07)

### Bug Fixes

* small prop missing on toggles ([#142](#142)) ([5a7931b](5a7931b))
* **toggle:** fix styling in different states ([#144](#144)) ([d65b8c4](d65b8c4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalbinaK BalbinaK BalbinaK left review comments

@felicia-haggqvist felicia-haggqvist felicia-haggqvist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pearofducks @BalbinaK @felicia-haggqvist