fix(w-field): ensure default error text is translated on time #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrorMsg in w-field Fix issues with validation message not being translated on time
github-actions bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
## [1.2.6-next.2](v1.2.6-next.1...v1.2.6-next.2) (2024-03-15) ### Bug Fixes * **w-field:** ensure default error text is translated on time ([#148](#148)) ([36dcf1c](36dcf1c))
github-actions bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
## [1.2.6](v1.2.5...v1.2.6) (2024-03-21) ### Bug Fixes * add missing aria attribute to w-textarea and w-select ([#146](#146)) ([191be0f](191be0f)) * **w-field:** ensure default error text is translated on time ([#148](#148)) ([36dcf1c](36dcf1c)) * **w-field:** use correct colors in label and hint/error text ([#150](#150)) ([fa3a621](fa3a621))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes WARP-519 and WARP-518
The
i18ncall is now moved tow-fieldin order for thevalidationMsgtranslation to trigger in the right moment.Additionally:
hasValidationErrorsis replaced withisInvalidto simplify the validation logic in the templateinvalidprop is now included in the validation checks, so when a component relies oninvalidprop when handling validation, it also contains default validation message and respective aria attributes