fix: update classnames #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use same way for applying classNames and remove repetitive code
BalbinaK
reviewed
Aug 7, 2024
BalbinaK
reviewed
Aug 7, 2024
BalbinaK
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Update class names that have been renamed in component-classes (this also includes class name changes to the
w-switchcomponent that was changed in this PR in the @warp-ds/css repo)Standardize the method for applying class names across all components.
Before: Different components used various methods (arrays, objects) to apply class names, resulting in inconsistent code and potential confusion.
For example:
const attentionClasses = computed(() => ({ [props.attentionClass]: true, [ccAttention.notCallout]: !props.callout, }));After: All components now consistently use arrays to define class names, which will improve consistency and readability.
For example:
const attentionClasses = computed(() => [props.attentionClass, !props.callout && ccAttention.notCallout]);How to test
Either link this branch with @warp-ds/css (
fix/cleanup-switch-toggle-classesbranch) or replace this for @warp-ds/css dependency in package.json:github:warp-ds/css#component-classes-cleanupwith thisgithub:warp-ds/css#fix/cleanup-switch-toggle-classes