-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bindkeys #537
Comments
After taking a deeper look, it seems |
@juliogarciag CC'ing @charlespierce as he's working on custom keybindings and this falls under that umbrella! |
are there plans to do left option as ESC+ instead of Meta? I use ESC+. which is insert-last-word on zsh all the time and I just get ≥ regardless of whether Left Option Key is Meta is enabled |
Same problem to me, and bindkey does not work for zsh autosuggestions. # zsh auto suggestions
source /usr/local/share/zsh-autosuggestions/zsh-autosuggestions.zsh
bindkey '^k' autosuggest-accept
bindkey '^j' autosuggest-execute |
From: Describe the bugTry putting the below in the ~/.zshrc
To ReproduceNo response Expected behaviourNo response Screenshotshttps://share.getcloudapp.com/7KuE7w6K Operating SystemNo response OS VersionNo response Additional contextNo other bindkey seems to present an issue |
From @hardselius via: Describe the bugI have the following snippet in my resume() {
fg
zle push-input
BUFFER=""
zle accept-line
}
zle -N resume
bindkey "^Z" resume It serves as a "toggle" for programs running in the terminal, e.g vim. To ReproduceSteps to reproduce:
Expected behaviourIn this case, I expect ScreenshotsNo response Operating SystemMacOS OS Version12.1 Additional contextNo response |
It's very convenient to be able to use |
@psbanka is "Left option key is meta" on for you? |
Oh, wow, that's great, @elviskahoro , thank you! The last place I expected to find that was under the |
@psbanka There's room to improve our discoverability. Where did you look for it? I'll see if we can get it added there, you're definitely not the first to ask! |
Zsh history expansion does not work From @r-thomson Describe the bugZsh's history expansion does not work in Warp (v0.2022.02.21.08.55.stable_00). It seems to work correctly in the stock Terminal app. To Reproduce
Expected behaviourElement 999 (shown in ScreenshotsNo response Operating SystemMacOS OS Version12.2.1 Additional contextHere's my dotfiles, if it helps |
Sorry for necrobumping this thread, but is there a plan / ETA for supporting bindkeys? This is a deal-breaker to me, in particular. |
I love the direction Warp is going (eg #625) but limiting the user to Warp-native solutions is too strict. I myself have a plethora of fzf-based-autocompletions (cf #149) which, in my case, are much more evolved than what Warp currently offers. I'd really like to use Warp as my daily driver because of its other features (eg blocks) but not being able to do what a vanilla Terminal + zsh shell can offer has prevented me from switching. |
Lack of support for any zsh keybindings is really a deal breaker for me using Warp. It's also just painfully inelegant. Zsh has a whole system for managing keybindings, which I've invested it, and Warp just throws that away. Even when there's a zsh keybinding defined that doesn't overlap with a Warp binding it still doesn't pass the event along. This also means that little tweaks on default zsh keybindings can't be changed. To use an example, I redefine some basic keybindings like this so that things like Ctrl-K ( edit: Also I think the lack of bindkey support could use a separate github issue clearly describing it. The main post of this issue doesn't mention keybindings, and I think that's a feature that can stand on its own. (It's also unlikely Warp would address all the missing features mentioned in this issue at the same time) |
I found a partial workaround: Once in Warp, just run My custom keybinding on Ctrl-K still doesn't work, but other custom bindings do, as well my own history searching method. Could make sense for occasional use. ¯_(ツ)_/¯ |
|
Well played, sir, lol. Yeah this is annoying eh, seems like a big miss. I can see how the embedded fuzzy search on command history would reduce my need to use Hopefully they can find a solution for this, the terminal is a phenomenal piece of tech otherwise. |
Most of the comments are about bindkeys, so I'm going to change this title + description to be about bindkeys. I made #1514 to keep the original issue description I'm really surprised there aren't more upvotes on this, because I hear a lot of anecdotal feedback about bindkeys, so changing the name in case it's confusion |
Can there be some sort of helper script that converts my .zshrc to a slimmed down .zshrc and auto-populates the .keybindings file and whatever else warp uses? Or at the least, ignores unsupported things instead of refusing to work entirely? |
As fresh user of Warp, I hit this issue. I cleared default key binding of My use case is to combine: Warp + Atuin: https://github.com/atuinsh/atuin (Currently impossible, I think) |
@Dentrax You are correct that it isn't possible to bind a key to an app like fzf. We'd have to explicitly build support for this into Warp's Input Editor, since it's native |
This is a shame, I was about to adopt Warp but this is making me reconsider. I have the following functionality defined in my fish config, which allows me to easily switch directories.
As bind doesn't work, I cannot use it. And there doesn't seem to be way to invoke custom functions with the Warp keybindings (only native keybinds). Would be happy to see this implemented, I don't necessarily care about Although it feels like the optimal design should simply support native features that are provided by the underlying shell. In this case, first simply support the features of the underlying shell, before adding gimmicky stuff on top. Edit: Actually I do care about |
I did not manage to use |
Warp also has Command Search which you can use to filter through the history as well. I hope this helps some with your use cases @fulmicoton |
(hi, Atuin maintainer here) We're more than happy to hook into Warp to make sure keybindings work, do you have any guidance? If supporting standards is off the table, anyways. |
Does warp support keyboard shortcut for history search. I prefer it over the default show history. Adding a up arrow shortcut doesn't work. ![]() |
+1 to having bindkey working. |
As a temporary fix, can you just parse such files and manually ignore all bindkey lines? |
This needs to be implemented ASAP as the user experience now is not good. It's pretty embarrassing this issue is open for 2 years. |
+1 |
I want to bind a key to a Fish function, currently it fails.. |
Everything that is said here is spot on. I hope Warp team actually looks into the issue and supports the underlying shell functionality. 🙏 |
Just chiming in to say that I would also like to see support for this. I use the zsh |
This is only thing which blocks me to switch to warp, unable to use my keybinding in .zshrc :( |
I'm also trying to use fzf shortcuts that work with "bind", and it's working flawlessly in item2, but not in warp :( a shame, I love warp! |
Well, was just configuring my Warp Installation but hit this roadblock, back to iTerm we go |
Total deal-breaker for me. All the cool features amount to nothing if they won't integrate with other tools that have earned their place in the ecosystem. Hopefully you guys can find a resolution. |
Is there any ETA ? |
Thanks to @sheldonhull over on the Atuin warp issue:
if I Edit: saw this mentioned earlier, sorry for the noise |
the |
Describe the bug
Right now, Warp just ignores the user's bindkeys and they don't do anything.
Please upvote if you want us to honor them
The text was updated successfully, but these errors were encountered: