Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct links to images does not work #14

Closed
myhrmans opened this issue Jan 22, 2022 · 5 comments
Closed

Direct links to images does not work #14

myhrmans opened this issue Jan 22, 2022 · 5 comments

Comments

@myhrmans
Copy link
Contributor

Hi there.

Tried to launch this using docker today, as you can see here: https://photoclass.myhrmans.com

Images load fine but when you open an image and copy the url to go directly to the image the following error is spotted out in the console:

Uncaught TypeError: Cannot read properties of null (reading 'getAttribute')
    at openPhoto ((index):66:29)
    at photos.js:7:1
    at photos.js:9:3

Using docker-compose.

@myhrmans
Copy link
Contributor Author

Another issue I just discovered is that the social media links are still visible even if they are commented out in the .env file.

@myhrmans
Copy link
Contributor Author

Looked though the code and it fails here
Tried to do the same thing in devtools.. wierd...
image

@myhrmans
Copy link
Contributor Author

Broke with this pull: #8. Added "id-" infront of all id´s.

This file still just have the name.

Can simply be fixed by this PR: #15

@waschinski
Copy link
Owner

Thanks for reporting and already fixing this issue! Much appreciated! Your PR has been merged and docker images should be up soon.

Regarding the social media links, have you tried commenting them in and just leave their values empty e.g. TWITTER_USERNAME=? You should also remove the comment at the end of the URL line, I think it's only being detected as a comment when the hash is at the very beginning of a line. Please let me know if that works.

@myhrmans
Copy link
Contributor Author

Awesome. If that does not fix it I will create another issue specifically for that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants