Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numeric-only image names break the arrow key JS. #8

Closed
danbush opened this issue Aug 3, 2021 · 2 comments
Closed

Numeric-only image names break the arrow key JS. #8

danbush opened this issue Aug 3, 2021 · 2 comments

Comments

@danbush
Copy link

danbush commented Aug 3, 2021

I'm pretty sure this is probably just a situation where something should be explicitly made a string, but I hadn't found where that should go because it was just easier for me to rename my files.
waschinski added a commit that referenced this issue Aug 8, 2021
@waschinski
Numeric-only names no longer breaking stuff #8
f8fff89
@waschinski
Copy link
Owner

Thanks for reporting this. Numeric IDs were indeed causing problems with the CSS selector so I simply added a prefix (id-) to the IDs to basically force them to be a string.

@danbush
Copy link
Author

danbush commented Aug 8, 2021

perfect, thats basically what I did as a temp fix but in reverse. thank you!

@danbush danbush closed this as completed Aug 8, 2021
@myhrmans myhrmans mentioned this issue Jan 22, 2022
Closed
zchryr pushed a commit to zchryr/photo-stream that referenced this issue Mar 21, 2023
@waschinski
Numeric-only names no longer breaking stuff waschinski#8
1648cc8 
Former-commit-id: f8fff89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danbush @waschinski