feat(scaler): Accounts for other providers running the lattice #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomastaylor312
force-pushed
the
feat/check_provider_existence
branch
from
22d11d1
to
97377fe
Compare
This PR contains a couple small changes I discovered while manually testing, but the large change is around the scaler algorithm for providers. Now a provider scaler will consider its job done if _any_ provider matching what it is expecting to be running. Closes wasmCloud#106 Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
thomastaylor312
force-pushed
the
feat/check_provider_existence
branch
from
97377fe
to
193f399
Compare
connorsmith256
approved these changes
May 31, 2023
| @@ -156,13 +156,13 @@ impl<S: ReadStore + Send + Sync + Clone> Scaler for ActorSpreadScaler<S> { | |||
| }, | |||
| ) | |||
| }) | |||
| .collect::<Vec<&WadmActorInstance>>() | |||
| .count() | |||
| .sum() | ||
| }) | ||
| .unwrap_or(0); | ||
| trace!(current = %current_count, expected = %count, "Calculated running actors, reconciling with expected count"); | ||
| trace!(current = %current_count, expected = %count, host_id = ?first_host.id, "Calculated running actors, reconciling with expected count"); | ||
| // TODO: Figure out why a new deploy doesn't scale things down properly |
There was a problem hiding this comment.
Is this an Eventually ™️ thing or should we have an issue filed to track?
There was a problem hiding this comment.
I was gonna file and forgot. Will file one now
There was a problem hiding this comment.
Oh whoops, wrong thing. But I was going to look at this in e2e. I did need to file that issue anyway
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a couple small changes I discovered while manually testing, but the large change is around the scaler algorithm for providers. Now a provider scaler will consider its job done if any provider matching what it is expecting to be running.
Closes #106