fix: write out policy data in a secret config correctly #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protochron
requested review from
autodidaddict,
brooksmtownsend,
thomastaylor312 and
connorsmith256
as code owners
protochron
force-pushed
the
fix_secret_config_data
branch
2 times, most recently
from
25e0c5c
to
ed0491c
Compare
In wasmCloud#307 we introduced secrets support, which works by storing secrets references as config in NATS KV. This fixes a bug in the way that we were serializing the configuration as JSON where we were overwriting the policy field which is required. Signed-off-by: Dan Norris <protochron@users.noreply.github.com>
protochron
force-pushed
the
fix_secret_config_data
branch
from
ed0491c
to
011482c
Compare
brooksmtownsend
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
In #307 we introduced secrets support, which works by storing secrets references as config in NATS KV. This fixes a bug in the way that we were serializing the configuration as JSON where we were overwriting the policy field which is required.
Related Issues
Release Information
0.13.0
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification