Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

feat: change delete name and add alias #876

Merged
merged 1 commit into from
Oct 10, 2023
Merged

feat: change delete name and add alias #876

merged 1 commit into from
Oct 10, 2023

Conversation

WallysFerreira
Copy link
Contributor

Feature or Problem

Use "del" as an alias and change actual name to "delete" for readability

Related Issues

#866

Consumer Impact

Nicer to read but still working as usual with either "del" or "delete".

Testing

Built on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Tested on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Manual Verification

Ran the unit tests and tested in my machine and codespace

Signed-off-by: Wallys Ferreira <wallysfsilva@gmail.com>
@WallysFerreira WallysFerreira changed the title change name and add alias feat: change delete name and add alias Oct 10, 2023
Copy link
Contributor

@connorsmith256 connorsmith256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution @WallysFerreira 🙌

@connorsmith256 connorsmith256 merged commit 119fc5b into wasmCloud:main Oct 10, 2023
23 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants