fix(provider-wit-bindgen): exported bundled arg invocation name #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vados-cosmonic
force-pushed
the
fix(provider-wit-bindgen)=exported-bundle-args-invocation-naming
branch
2 times, most recently
from
f5f070c
to
a3382ae
Compare
This commit fixes a bug in determining the struct name for bundled exports. Code that was using expected a WIT interface name was receiving a WIT inteface path (which is `.`-delimited), and attempting to use it directly, rather that converting to a valid Rust identifier. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
fix(provider-wit-bindgen)=exported-bundle-args-invocation-naming
branch
from
a3382ae
to
24068ae
Compare
thomastaylor312
approved these changes
Feb 26, 2024
vados-cosmonic
deleted the
fix(provider-wit-bindgen)=exported-bundle-args-invocation-naming
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This commit fixes a bug in determining the struct name for bundled exports. Code that was using expected a WIT interface name was receiving a WIT inteface path (which is
.-delimited), and attempting to use it directly, rather that converting to a valid Rust identifier.Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification