fix(rpc): Prevents early provider exit when logger is set #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomastaylor312
commented
Mar 7, 2022
| crate::channel_log::init_receiver(log_rx); | ||
| match crate::channel_log::init_logger() { | ||
| Ok(log_rx) => crate::channel_log::init_receiver(log_rx), | ||
| // TODO(thomastaylor312): This is brittle, but the init_logger function is public and this |
There was a problem hiding this comment.
If we are ok with this for now, I'll create an issue before merging this PR to address this
Previous to this change, if a provider set a logger, it would cause the provider to exit early. This changes the setup to simply log a message if the provider already created a logger rather than exiting early Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
thomastaylor312
force-pushed
the
fix/provider_log_init
branch
from
a58cbaf
to
e326d47
Compare
stevelr
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this change, if a provider set a logger, it would cause the provider
to exit early. This changes the setup to simply log a message if the provider
already created a logger rather than exiting early