Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module::len_globals() incorrectly returns number of linear memories #735

Closed
graydon opened this issue Jun 27, 2023 · 3 comments
Closed

Module::len_globals() incorrectly returns number of linear memories #735

graydon opened this issue Jun 27, 2023 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@graydon
Copy link
Contributor

graydon commented Jun 27, 2023

I believe the code for len_globals is wrong here -- a copy-paste error from len_memories above:

https://github.com/paritytech/wasmi/blob/799995da7afb0ae02bb4fd1c9f242fe07c7ad824/crates/wasmi/src/module/mod.rs#L187-L189
@Robbepop
Copy link
Member

@graydon good catch! very strange that this one was not caught before. Going to need further inspection.

@Robbepop Robbepop added bug Something isn't working good first issue Good for newcomers labels Jun 27, 2023
@Robbepop Robbepop changed the title len_globals() returns memories.len() Module::len_globals incorrectly returns number of linear memories Jun 27, 2023
@Robbepop Robbepop changed the title Module::len_globals incorrectly returns number of linear memories Module::len_globals() incorrectly returns number of linear memories Jun 27, 2023
@deepto98
Copy link

deepto98 commented Jul 1, 2023

Can I work on this?

@Robbepop
Copy link
Member

Robbepop commented Jul 2, 2023

@deepto98 Yes please. :)

behkod added a commit to behkod/wasmi that referenced this issue Jul 24, 2023
@behkod
fixes wasmi-labs#735: copy paste typo
3b62777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@graydon @Robbepop @deepto98