Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize fuel costs to roughly 1 fuel per executed instruction #705

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Mar 3, 2023

Closes #701.

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.51ms 1.51ms ⚪ 0.62% 1.38ms 1.36ms 🟢 -0.77% 🟢 -10%
execute/
bare_call_0/typed
1.13ms 1.14ms ⚪ -0.05% 959.08µs 945.68µs 🟢 -1.51% 🟢 -17%
execute/
bare_call_1
1.56ms 1.56ms 🔴 -0.52% 1.44ms 1.48ms 🔴 3.20% 🟢 -5%
execute/
bare_call_16
2.48ms 2.55ms 🔴 2.82% 3.36ms 3.79ms 🔴 12.73% 🟢 49%
execute/
bare_call_16/typed
2.05ms 1.78ms 🟢 -13.32% 1.62ms 1.63ms ⚪ 0.42% 🟢 -9%
execute/
bare_call_1/typed
1.23ms 1.23ms ⚪ 0.55% 1.24ms 1.35ms 🔴 8.86% 🟢 9%
execute/
bare_call_4
1.74ms 1.77ms ⚪ 1.34% 1.79ms 1.81ms ⚪ 1.03% 🟢 2%
execute/
bare_call_4/typed
1.27ms 1.28ms ⚪ 1.10% 1.20ms 1.19ms ⚪ -1.26% 🟢 -8%
execute/
br_table
1.32ms 1.30ms ⚪ -1.03% 1.47ms 1.43ms 🟢 -2.40% 🟢 10%
execute/
count_until
707.69µs 651.45µs 🟢 -8.02% 1.01ms 980.77µs 🟢 -2.71% 🟡 51%
execute/
factorial_iterative
368.84µs 342.00µs 🟢 -7.39% 449.24µs 447.57µs ⚪ -0.02% 🟢 31%
execute/
factorial_recursive
598.76µs 594.70µs ⚪ -0.72% 837.84µs 849.71µs 🔴 1.48% 🟢 43%
execute/
fibonacci_iter
1.47ms 1.64ms 🔴 11.91% 2.06ms 2.05ms ⚪ 1.13% 🟢 25%
execute/
fibonacci_rec
4.94ms 4.83ms 🟢 -1.87% 7.50ms 7.31ms 🟢 -2.44% 🟡 52%
execute/
fibonacci_tail
1.20ms 1.22ms 🔴 1.16% 1.56ms 1.53ms 🟢 -1.78% 🟢 26%
execute/
global_bump
800.67µs 793.71µs ⚪ -0.88% 1.35ms 1.32ms 🟢 -2.16% 🟡 66%
execute/
global_const
811.29µs 715.35µs 🟢 -11.69% 1.17ms 1.17ms ⚪ 0.00% 🟡 64%
execute/
host_calls
35.69µs 36.53µs ⚪ 1.15% 50.48µs 46.78µs 🟢 -7.44% 🟢 28%
execute/
memory_fill
1.21ms 1.21ms ⚪ -0.44% 1.76ms 1.76ms ⚪ 0.33% 🟢 46%
execute/
memory_sum
1.19ms 1.19ms ⚪ -0.10% 1.79ms 1.83ms 🔴 3.41% 🟡 55%
execute/
memory_vec_add
2.39ms 2.39ms ⚪ 0.05% 3.84ms 3.94ms 🔴 2.76% 🟡 65%
execute/
recursive_is_even
1.05ms 1.00ms 🟢 -4.29% 1.60ms 1.68ms 🔴 4.41% 🟡 67%
execute/
recursive_ok
122.42µs 122.12µs ⚪ -0.30% 190.21µs 194.19µs 🔴 2.07% 🟡 59%
execute/
recursive_scan
157.70µs 157.25µs ⚪ -0.57% 238.93µs 242.38µs ⚪ 1.07% 🟡 54%
execute/
recursive_trap
12.46µs 12.42µs ⚪ -0.21% 20.54µs 21.14µs 🔴 2.76% 🟡 70%
execute/
regex_redux
499.77µs 496.71µs ⚪ -0.69% 815.38µs 807.36µs ⚪ -0.78% 🟡 63%
execute/
rev_complement
455.77µs 458.07µs ⚪ 0.61% 719.64µs 713.33µs ⚪ -1.05% 🟡 56%
execute/
tiny_keccak
325.63µs 341.69µs 🔴 4.72% 552.79µs 542.21µs ⚪ -1.40% 🟡 59%
execute/
trunc_f2i
781.09µs 772.03µs ⚪ -1.19% 1.46ms 1.39ms 🟢 -4.92% 🟡 80%
instantiate/
wasm_kernel
54.63µs 52.60µs 🟢 -4.06% 55.43µs 56.91µs 🔴 3.23% 🟢 8%
translate/
erc1155
236.94µs 235.51µs ⚪ -0.41% 441.03µs 444.02µs ⚪ 0.49% 🟡 89%
translate/
erc20
114.86µs 114.39µs ⚪ -0.45% 211.32µs 216.17µs 🔴 2.24% 🟡 89%
translate/
erc721
163.38µs 162.78µs ⚪ -0.15% 309.77µs 314.40µs 🔴 1.64% 🟡 93%
translate/
spidermonkey
0.00ns 0.00ns ⚪ 0.36% 0.00ns 0.00ns ⚪ 0.60% 🟢 0%
translate/
wasm_kernel
4.19ms 4.19ms ⚪ -0.30% 7.96ms 8.06ms 🔴 1.34% 🟡 92%

Link to pipeline

@Robbepop Robbepop merged commit cf7736f into master Mar 3, 2023
@Robbepop Robbepop deleted the rf-normalized-fuel-costs branch March 3, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust fuel costs of most instruction to 1 fuel
2 participants