Validate types of instructions in constant expressions #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
validate-types-const-expr
branch
from
f70e355
to
92938dc
Compare
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
=======================================
Coverage 99.32% 99.32%
=======================================
Files 50 50
Lines 13992 14075 +83
=======================================
+ Hits 13897 13980 +83
Misses 95 95 |
gumb0
force-pushed
the
validate-types-const-expr
branch
2 times, most recently
from
1305ce0
to
4909d2e
Compare
axic
approved these changes
Jul 22, 2020
|
I think it is a bit confusing that "constant constant expression" are validated in |
gumb0
force-pushed
the
validate-types-const-expr
branch
from
4909d2e
to
e9d79c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type mismatch when constant expression uses
global.getlooks to be not covered by spec tests (passed tests don't change here when I disable it).