Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "submit button label" option to EntityForm #15

Closed
Martinsos opened this issue Mar 11, 2020 · 1 comment
Closed

Add "submit button label" option to EntityForm #15

Martinsos opened this issue Mar 11, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Martinsos
Copy link
Member

We want to be able to specify button label for EntityForm submit button.

Probably most relevant piece of code to start from is here: https://github.com/wasp-lang/wasp/blob/master/waspc/src/Wasp/EntityForm.hs#L54 -> here it should be added as Submit button option.
There are really three parts to this change:

  1. As mentioned above, expand Wasp.EntityForm with submit button label option.
  2. Modify parser so it parses this option.
  3. Modify generator so it appropriately renders this button.

We should also remove, from generated code, option to modify this label, which is currently there -> it is not needed anymore if we do this.

While this issue requires changes to the whole system, I believe it is good "starter" issue as it can be mostly done by copying how it is done for other EntityForm options, is conceptually simple, all is clear regarding requirements, and it teaches you about the whole waspc.

@Martinsos Martinsos added enhancement New feature or request good first issue Good for newcomers labels Mar 11, 2020
@Martinsos
Copy link
Member Author

Not relevant any more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant