Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'utf-8' fallback encoding for RSS feed #63

Merged
merged 1 commit into from
Jun 20, 2017
Merged

Fix 'utf-8' fallback encoding for RSS feed #63

merged 1 commit into from
Jun 20, 2017

Conversation

k0st1x
Copy link

@k0st1x k0st1x commented Jun 20, 2017 •
edited
Loading

Fixing #62 issue

@k0st1x k0st1x mentioned this pull request Jun 20, 2017
Closed
@ralarcon
Copy link
Collaborator

I will accept this PR but not sure when we are going to release a new version of nugets.

Best Regards and thank you for your collaboration.

@ralarcon ralarcon merged commit 540b7b7 into wasteam:DEV Jun 20, 2017
@ralarcon
Copy link
Collaborator

I have just realize that the SetEncoding instruction where you have added it will always overwrite the encoding logic of that method. Shouldn't be in an else statement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralarcon ralarcon ralarcon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k0st1x @ralarcon