Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Feature/add ownership and date #301

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Conversation

baristaGeek
Copy link
Collaborator

Description

This small PR allows us to provide PR authorship and longevity, which is a change that allows us to show value the same way which we're already doing with our VS Code extension. Looks like this:

Screen Shot 2023-09-19 at 5 15 25 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore: cleanup/renaming, etc
  • RFC

Notes

Not all services have the possibility of retrieving a date. But for those that do, we also have the opportunity to add this info to such on a separate PR

Acceptance

@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
watermelon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 9:08pm

@watermelon-copilot-for-code-review
Copy link

watermelon-copilot-for-code-review bot commented Sep 19, 2023

WatermelonAI Summary

The two commits in the PR are related to adding ownership and date information to our codebase. The first commit removes a special case for GitHub, while the second commit merges the dev branch into the feature branch. The PR aims to provide authorship and longevity information similar to what our VS Code extension already does. Although not all services can retrieve a date, this PR allows us to add this information to the services that can. Overall, the PR adds functionality to display ownership and date information.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Click here to login to Slack
Notion Pages deactivated by baristaGeek
Linear Tickets deactivated by baristaGeek
Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶

@@ -21,8 +22,10 @@ const generalMarkdownHelper = ({
markdown = `\n #### ${systemResponseName}`;
markdown += (value?.data || [])
.map(
({ number, title, link, body }) =>
`\n - [#${number} - ${title}](${link}) \n`
({ number, title, link, body, author, created_at }) =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:chef_kiss:

@@ -0,0 +1,41 @@
export default function getRelativeDate(isoDateString: string): string {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing we're never revisiting this haha

@EstebanDalelR EstebanDalelR mentioned this pull request Sep 20, 2023
8 tasks
@baristaGeek baristaGeek merged commit 3f91367 into dev Sep 20, 2023
3 checks passed
@baristaGeek baristaGeek deleted the feature/add-ownership-and-date branch September 20, 2023 21:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants