Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

REmove github special case #303

Conversation

EstebanDalelR
Copy link
Member

Description

Removes the per- service case and uses a per-parameter check

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore: cleanup/renaming, etc
  • RFC

Notes

Will allow sending from any service the author and date without code changes

Acceptance

@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
watermelon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 1:22pm

@watermelon-copilot-for-code-review

WatermelonAI Summary

The first commit in this Pull Request removes a special case for Github and instead implements a per-parameter check. This change allows the author and date to be sent from any service without requiring code changes. It is a bug fix that improves the functionality of the system and does not introduce any breaking changes.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Slack Threads deactivated by EstebanDalelR
Notion Pages deactivated by EstebanDalelR
Linear Tickets deactivated by EstebanDalelR
Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶

@EstebanDalelR EstebanDalelR merged commit eb45693 into feature/add-ownership-and-date Sep 20, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants