Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Fix/broken deactivation text #304

Merged
merged 7 commits into from
Sep 20, 2023
Merged

Fix/broken deactivation text #304

merged 7 commits into from
Sep 20, 2023

Conversation

EstebanDalelR
Copy link
Member

Description

Users were seeing a deactivated notice when we found no error

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore: cleanup/renaming, etc
  • RFC

Notes

Acceptance

@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
watermelon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 8:26pm

@watermelon-copilot-for-code-review
Copy link

watermelon-copilot-for-code-review bot commented Sep 20, 2023

WatermelonAI Summary

The 7 commits in this Pull Request are focused on fixing an issue with a broken deactivation text. The commits include adding the date to the text, calculating the relative date, printing the author of the PR, removing unnecessary console logs, removing a special case for Github, and fixing a helper text. Overall, these changes reflect the business logic of addressing a bug and improving the deactivation text for a better user experience.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence

Slack Threads

Notion Pages

Linear Tickets

Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶

@@ -21,12 +22,12 @@ const generalMarkdownHelper = ({
markdown = `\n #### ${systemResponseName}`;
markdown += (value?.data || [])
.map(
({ number, title, link, body }) =>
`\n - [#${number} - ${title}](${link}) \n`
({ number, title, link, body, author, created_at }) =>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, comes from #301 as to not have conflicts, when that one is merged there will be no diff

@baristaGeek baristaGeek merged commit 7fbb7af into dev Sep 20, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants