Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created form_example.py #22

Merged
merged 4 commits into from
May 22, 2019
Merged

Created form_example.py #22

merged 4 commits into from
May 22, 2019

Conversation

mark0203
Copy link
Contributor

The Nerodia equivalent Watirs example from http://watir.com/guides/form-example/

The Nerodia equivalent Watirs example from http://watir.com/guides/form-example/
Copy link
Collaborator

@lmtierney lmtierney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please address the flake8 issues: https://travis-ci.org/watir/nerodia/jobs/533491320

# Based on http://watir.com/guides/form-example/

from nerodia.browser import Browser
#from selenium.webdriver.common.keys import Keys #needed to send keys
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused import.

@mark0203
Copy link
Contributor Author

I don't know what a flake8 thing is.

@lmtierney
Copy link
Collaborator

Flake8 is a library that checks against a style guide. This is checked every commit and it's failing on two items with your code:

https://travis-ci.org/watir/nerodia/jobs/535363016#L242-L243

@mark0203
Copy link
Contributor Author

I think I finally got where to find the mistake
./examples/form_example.py:32:1: W293 blank line contains whitespace

@lmtierney
Copy link
Collaborator

I highlighted what needed to be fixed with the link https://travis-ci.org/watir/nerodia/jobs/535363016#L242-L243

You fixed one, the other is:

./examples/form_example.py:6:10: E261 at least two spaces before inline comment

If you read that, it's saying ./examples/form_example.py at line 6 character position 10. There needs to be 2 spaces before an inline comment

@lmtierney lmtierney merged commit 3f8512e into watir:master May 22, 2019
@lmtierney
Copy link
Collaborator

Merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants