Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable analytics headers in browser to fix cors issues #932

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

dpopp07
Copy link
Contributor

@dpopp07 dpopp07 commented Aug 8, 2019

This will hopefully be a temporary fix until we have a better solution. Should resolve #884

this will hopefully be a temporary fix until we have a better solution
@codecov-io
Copy link

codecov-io commented Aug 8, 2019

Codecov Report

Merging #932 into master will increase coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #932      +/-   ##
=========================================
+ Coverage   54.35%   54.4%   +0.05%     
=========================================
  Files          18      18              
  Lines        4502    4505       +3     
  Branches      905     906       +1     
=========================================
+ Hits         2447    2451       +4     
+ Misses       2053    2052       -1     
  Partials        2       2
Impacted Files Coverage Δ
lib/common.ts 92.3% <66.66%> (-7.7%) ⬇️
test/resources/auth_helper.js 100% <0%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8111263...bdcf9d6. Read the comment docs.

@germanattanasio germanattanasio merged commit bba47a0 into master Aug 13, 2019
@germanattanasio germanattanasio deleted the disable-headers-in-browser branch August 13, 2019 14:26
watson-github-bot pushed a commit that referenced this pull request Aug 13, 2019
## [4.3.4](v4.3.3...v4.3.4) (2019-08-13)

### Bug Fixes

* disable analytics headers in browser to fix cors issues ([bdcf9d6](bdcf9d6))
* disable analytics headers in browser to fix cors issues ([#932](#932)) ([bba47a0](bba47a0))
@watson-github-bot
Copy link
Member

🎉 This PR is included in version 4.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Assistant2 CORS policy error. Access to XMLHttpRequest: No 'Access-Control-Allow-Origin' header.
4 participants