Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compare-comply): new model ContractCurrencies added #935

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Conversation

dpopp07
Copy link
Contributor

@dpopp07 dpopp07 commented Aug 20, 2019

Regenerate CnC with new model and type fixes.

Also, fix copyrights in generated unit tests

* also, fix copyrights in generated unit tests
@dpopp07 dpopp07 requested a review from mediumTaj August 20, 2019 18:31
@codecov-io
Copy link

codecov-io commented Aug 20, 2019

Codecov Report

Merging #935 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #935      +/-   ##
=========================================
+ Coverage   54.36%   54.4%   +0.04%     
=========================================
  Files          18      18              
  Lines        4505    4505              
  Branches      906     906              
=========================================
+ Hits         2449    2451       +2     
+ Misses       2054    2052       -2     
  Partials        2       2
Impacted Files Coverage Δ
compare-comply/v1.ts 54.09% <ø> (ø) ⬆️
test/resources/auth_helper.js 100% <0%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b7004...a79b118. Read the comment docs.

Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@dpopp07 dpopp07 merged commit 132ad09 into master Aug 20, 2019
@dpopp07 dpopp07 deleted the regen-cnc branch August 20, 2019 21:17
watson-github-bot pushed a commit that referenced this pull request Aug 20, 2019
# [4.4.0](v4.3.4...v4.4.0) (2019-08-20)

### Features

* **compare-comply:** new model ContractCurrencies added ([#935](#935)) ([132ad09](132ad09))
@watson-github-bot
Copy link
Member

🎉 This PR is included in version 4.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

dpopp07 added a commit that referenced this pull request Aug 21, 2019
* also, fix copyrights in generated unit tests

(cherry picked from commit 132ad09)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants