Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Pipelines is not detected #22

Closed
vtbassmatt opened this issue Sep 26, 2018 · 3 comments
Closed

Azure Pipelines is not detected #22

vtbassmatt opened this issue Sep 26, 2018 · 3 comments

Comments

@vtbassmatt
Copy link
Contributor

Details:

Environment variables

Environment variables example
// Add a list of actual environment variables available to the build here
// Please keep the blank line above and below the code block
// WARNING: Be careful not to include any private or otherwise sensitive information

Additional context
Disclosure: I'm a product manager on Azure Pipelines.

vtbassmatt added a commit to vtbassmatt/ci-info that referenced this issue Sep 26, 2018
@DSchau
Copy link

DSchau commented Nov 26, 2018

@vtbassmatt would you be able to PR your changes in f01fe13 so we can get azure pipelines support? We're using azure pipelines over at gatsbyjs/gatsby and we'd love the ability to detect CI for Azure Pipelines just like we do for Travis/CircleCI/etc. :)

Ha - you did. I'll chime in there :)

DSchau added a commit to DSchau/gatsby that referenced this issue Nov 26, 2018
In gatsbyjs#10128, we added test report tasks to Azure pipelines. Unfortunately,
this adds some additional overhead and coverage type stuff in _local_
development that we probably don't want.

This PR addresses this issue, and conditionally detects whether running
in CI. If running in CI (e.g. Azure Pipelines, Circle, etc.) it will add
the additional coverage reporter and coverage functionality.

Note: this is currently blocked by watson/ci-info#22
DSchau pushed a commit to gatsbyjs/gatsby that referenced this issue Nov 27, 2018
* test: do not report coverage unless in CI

In #10128, we added test report tasks to Azure pipelines. Unfortunately,
this adds some additional overhead and coverage type stuff in _local_
development that we probably don't want.

This PR addresses this issue, and conditionally detects whether running
in CI. If running in CI (e.g. Azure Pipelines, Circle, etc.) it will add
the additional coverage reporter and coverage functionality.

Note: this is currently blocked by watson/ci-info#22

* add GENERATE_JEST_REPORT env var and use it with azure pipelines

* use var to hold normalized (boolean) val from env var
@watson
Copy link
Owner

watson commented Dec 5, 2018

Thanks for your PR #23 - Azure Pipelines will now be supported as of the next release which I will make shortly 💯

@watson watson closed this as completed Dec 5, 2018
@watson
Copy link
Owner

watson commented Dec 5, 2018

Support for Azure Pipelines has just been released in v2.0.0

gpetrioli pushed a commit to gpetrioli/gatsby that referenced this issue Jan 22, 2019
* test: do not report coverage unless in CI

In gatsbyjs#10128, we added test report tasks to Azure pipelines. Unfortunately,
this adds some additional overhead and coverage type stuff in _local_
development that we probably don't want.

This PR addresses this issue, and conditionally detects whether running
in CI. If running in CI (e.g. Azure Pipelines, Circle, etc.) it will add
the additional coverage reporter and coverage functionality.

Note: this is currently blocked by watson/ci-info#22

* add GENERATE_JEST_REPORT env var and use it with azure pipelines

* use var to hold normalized (boolean) val from env var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants