Fix crash on error when using stream #52
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output stream was not closed after emitting the error. This was causing the main Node thread to crash with a segmentation fault, maybe when then spawn is cleaned up while still being attached to the open stream. This should fix #46 too
Happening for me on Node v10 and v12, possibly older versions are okay?
From the docs
https://nodejs.org/api/stream.html#stream_event_error