Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pixel light support #383

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

daleeidd
Copy link
Collaborator

@daleeidd daleeidd commented Dec 27, 2019

This will help address #357
There is also vertex light support with #382

Experimental support for pixel lights. Pixel lights can be point, spot or directional lights which are set to Important or in some cases Automatic.

Red Pixel
Point Light

Green Pixel
Spot Light

About

This is a very rough PR. It will need a lot of work.

Pass and Blending

Adds another pass and uses BlendOp Max. This prevents the more egregious artefacts. Improving the extra pass is a better way to go. Distilling the pass to only perform the necessary work for the light itself is the ideal.

Performance

Only the tiles which are affected by the light will require additional passes. Performance will depend on how many lights and their coverage. Performance can be improved by removing unnecessary work.

Issues

Plenty. I haven't properly worked through everything so some features are broken or misused.

Technical Debt

In its current form, technical debt is pretty high.

Directional Light

Based on light direction rather than camera to light for spot lights.

Will be easier to track changes by committing this now.
@daleeidd daleeidd marked this pull request as ready for review April 22, 2020 11:47
@daleeidd daleeidd marked this pull request as draft April 22, 2020 12:08
@daleeidd
Copy link
Collaborator Author

Oops... made changes to wrong PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants